Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Leverage Terra's circuit library #395

Open
mtreinish opened this issue Apr 20, 2020 · 3 comments
Open

Leverage Terra's circuit library #395

mtreinish opened this issue Apr 20, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@mtreinish
Copy link
Collaborator

What is the expected behavior?

Since terra 0.13.0 the qiskit.circuit.library path has existed for common circuits that can be used as building blocks as part of larger circuits. Most of the circuits modules in ignis are probably a good fit to live in the terra circuit library (so they are easily used independently of ignis). We should probably start migrating circuits to be in a form that works in the library (some already are like the qv model circuit), and ignis should start consuming the library for circuits where it can.

@mtreinish mtreinish added the enhancement New feature or request label Apr 20, 2020
mtreinish added a commit to mtreinish/qiskit-ignis that referenced this issue Jul 29, 2020
This commit starts the process of using the terra circuits library by
refactoring the quantum volume circuit generator function to internally
use the quantum volume circuit from the library instead of constructing
it manually. It also tries to rationalize the input parameters since
several didn't have any effect and others were not properly listed as
required.

Partially addresses qiskit-community#395
@ShellyGarion
Copy link
Contributor

Which circuit methods from Terra's circuits library could be used in ignis (except of QV)?
Which circuit methods should be moved from ignis to Terra's circuit library?
For example, do we think that RB circuits (random Cliffords + inverse gate) should be moved to Terra?
Circuits used for characterization?

@mtreinish
Copy link
Collaborator Author

mtreinish commented Jul 30, 2020

I don't think that there is anything else in the library currently (but I haven't checked exhaustively). But I think we should look at moving most if not all of the circuit generators to use the library over time. So RB circuits, characterization circuits etc all seem like a better fit in the library and we can have ignis use them from there.

@ShellyGarion
Copy link
Contributor

Possible candidates to move from ignis to terra are the entanglement circuits, see the comment in:
https://github.com/Qiskit/qiskit-ignis/blob/master/qiskit/ignis/verification/entanglement/__init__.py

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants