This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Add python 3.8 support and deprecate python 3.5 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for running ignis under python 3.8. It does this by adding the trove classifiers to the package metadata and adding a test job for python 3.8 At the same time this commit starts the deprecation window for python 3.5. Python 3.5 goes end of life by upstream python in Sept. 2020. We should give our users running with python 3.5 (which is about 10% of qiskit users this year based on pypi data) fair notice that when upstream python stops supporting it we do as well. Corresponding to this change, terra is going to start raising a warning when anything from qiskit.* is imported, see: Qiskit/qiskit#3268
This was referenced Nov 13, 2019
This adds installing aer from source locally so that we can depend on aer's in progress 3.8 support. When aer 0.4.0 is released we can remove this since the published version will have 3.8 wheels present.
Now that aer 0.4.0 is released we don't need to build it from source anymore. This commit updates the jobs to just aer from the latest release for all jobs.
|
@chriseclectic this should be ready to merge now |
|
@mtreinish Can you change the travis script so that stage 1 is lint, py3.7 linux, and py 3.7 osx rather than lint + py3.5 linux. Then the later test stage can be the remaining pythons 3.5, 3.6, 3.8 |
Ok, done in: 776fd18 |
chriseclectic
approved these changes
Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds support for running ignis under python 3.8. It does
this by adding the trove classifiers to the package metadata and adding
a test job for python 3.8 At the same time this commit starts the
deprecation window for python 3.5. Python 3.5 goes end of life by
upstream python in Sept. 2020. We should give our users running with
python 3.5 (which is about 10% of qiskit users this year based on pypi
data) fair notice that when upstream python stops supporting it we do as
well. Corresponding to this change, terra is going to start raising a
warning when anything from qiskit.* is imported, see:
Qiskit/qiskit#3268
Details and comments
Python's documented branch support status and EoL dates are listed here:
https://devguide.python.org/#branchstatus
Waiting on upstream dependencies