This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Interleaved RB option to keep the original interleaved element #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkanazawa1989
suggested changes
Jan 14, 2021
There was a problem hiding this comment.
Thanks @gadial for the patch! This looks good to me. Just minor comment.
| @@ -202,6 +211,7 @@ def randomized_benchmarking_seq(nseeds: int = 1, | |||
| Union[List[QuantumCircuit], List[Instruction], | |||
| List[qiskit.quantum_info.operators.symplectic.Clifford], | |||
| List[CNOTDihedral]]] = None, | |||
| keep_original_interleaved_elem: Optional[bool] = False, | |||
There was a problem hiding this comment.
Can this default to True to reproduce conventional behavior?
There was a problem hiding this comment.
The current behavior of RB is to convert the interleaved element to the group representation, which is what happens when keep_original_interleaved_elem == False. I wish to keep it default in order to avoid impacting existing code.
There was a problem hiding this comment.
I'm now convinced that True is the correct default value, although it will require to pass False explicitly to the existing tests.
nkanazawa1989
previously approved these changes
Jan 14, 2021
ShellyGarion
previously approved these changes
Jan 14, 2021
chriseclectic
approved these changes
Mar 24, 2021
mtreinish
added
the
Changelog: New Feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a boolean switch
keep_original_interleaved_elemto therandomized_benchmarking_seqcircuit generator of randomized benchmarking.Currently, the generator obtains an element to interleave, converts it to a group element, obtains a circuit representation of that element and adds it to the RB circuit. This usually results in a change even if the original element was a single instruction (e.g.
SwapGateobject will be converted to circuit comprising ofCXgates).If
keep_original_interleaved_elem == True, the original instruction/circuit is retained and used in the circuit as is. The code still needs to be able to convert it to a group element in order to invert the circuit at the end, and so the switch does not enable one to use non-group gates (e.g. usingTgate for the Clifford group).Summary
Details and comments