Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Remove ParametrizedSchedule dependency #592

Conversation

nkanazawa1989
Copy link
Contributor

Summary

Remove dependency on ParametrizedSchedule as per Qiskit/qiskit#6949

Details and comments

@nkanazawa1989 nkanazawa1989 changed the title Removed ParametrizedSchedule Remove ParametrizedSchedule dependency Aug 26, 2021
@mtreinish mtreinish added this to the 0.7 milestone Aug 27, 2021
Copy link

@taalexander taalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Is there someone else that should review?

@nkanazawa1989
Copy link
Contributor Author

I don't think so. We can merge this and remove ParametrizedSchedule from terra.

Copy link
Collaborator

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing here is that the minimum terra version in the requirements list is 0.13 iirc. I don't think that this pr will work with a terra version that old. Can you bump the minimum required version to the one where this will work?

@nkanazawa1989
Copy link
Contributor Author

Thanks @mtreinish I realized Ignis doesn't provide requirements file but they are hard-coded in the setup file. The requirements for terra 0.13 is already there.
https://github.com/Qiskit/qiskit-ignis/blob/15c2be1cbc80edb637ce5a80f2c9101adfd8fc44/setup.py#L21-L27

@taalexander
Copy link

Is this good to go @mtreinish?

@mtreinish
Copy link
Collaborator

Was the pulse builder syntax added in terra 0.13.0? I can't remember and I didn't see it mentioned in the release notes anywhere. If it was then yeah this is good to go. I just thought it was more recent than 0.13.0

@nkanazawa1989
Copy link
Contributor Author

There was no release note for the builder but this is the first PR Qiskit/qiskit#4174
Seems like terra > 0.15 is necessary?

@nkanazawa1989
Copy link
Contributor Author

Set terra version 0.15.1 according to https://qiskit.org/documentation/release_notes.html

0.20.0 0.15.1 0.6.1 0.4.0 0.8.0 0.7.5 2020-08-10

Please let me know if I'm wrong.

@mtreinish
Copy link
Collaborator

Yep it looks like it was first released in 0.15.0: https://github.com/Qiskit/qiskit-terra/releases/tag/0.15.0 (there was a changelog entry for the PR despite not having a release note :/ ) so setting the minimum to 0.15.x is appropriate

@mtreinish mtreinish merged commit 9cd8ad6 into qiskit-community:master Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants