-
Notifications
You must be signed in to change notification settings - Fork 160
Remove ParametrizedSchedule dependency #592
Remove ParametrizedSchedule dependency #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me. Is there someone else that should review?
I don't think so. We can merge this and remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing here is that the minimum terra version in the requirements list is 0.13 iirc. I don't think that this pr will work with a terra version that old. Can you bump the minimum required version to the one where this will work?
Thanks @mtreinish I realized Ignis doesn't provide requirements file but they are hard-coded in the setup file. The requirements for terra 0.13 is already there. |
Is this good to go @mtreinish? |
Was the pulse builder syntax added in terra 0.13.0? I can't remember and I didn't see it mentioned in the release notes anywhere. If it was then yeah this is good to go. I just thought it was more recent than 0.13.0 |
There was no release note for the builder but this is the first PR Qiskit/qiskit#4174 |
Set terra version 0.15.1 according to https://qiskit.org/documentation/release_notes.html
Please let me know if I'm wrong. |
Yep it looks like it was first released in 0.15.0: https://github.com/Qiskit/qiskit-terra/releases/tag/0.15.0 (there was a changelog entry for the PR despite not having a release note :/ ) so setting the minimum to 0.15.x is appropriate |
Summary
Remove dependency on
ParametrizedSchedule
as per Qiskit/qiskit#6949Details and comments