Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Don't include docs in discovered packages #611

Merged
merged 1 commit into from
May 6, 2022
Merged

Don't include docs in discovered packages #611

merged 1 commit into from
May 6, 2022

Conversation

BastianZim
Copy link
Contributor

Summary

Currently, docs is included as a separate package. This pollutes the user environment when installing the package.

Details and comments

I have not added a changelog because it is such a small change. Let me know if I should.

BastianZim added a commit to BastianZim/staged-recipes that referenced this pull request May 5, 2022
@BastianZim
Don't import docs anymore
6853fc1 
Fixed in qiskit-community/qiskit-ignis#611
@BastianZim
Copy link
Contributor Author

I know this package is maintenance-only but I would need this downstream still. Thanks!

@mtreinish
Copy link
Collaborator

I know this package is maintenance-only but I would need this downstream still. Thanks!

It's probably the last chance for us to include this. I was just preparing to EoL the package next month (I've got the pieces started here Qiskit/qiskit#1487 ). Do you need a bugfix release to include this or is merging it sufficient for your use case?

@BastianZim
Copy link
Contributor Author

Thank you! Bugfix would be nice so that I can clean up the package downstream.
I'm using this because I'm managing the distribution in conda-forge where I included the patch for now but a clean recipe would be nice for archiving everything.
But if not possible, no worries.

@mtreinish mtreinish merged commit ce9c594 into qiskit-community:master May 6, 2022
@BastianZim
Copy link
Contributor Author

Thank you!

@BastianZim BastianZim deleted the patch-1 branch May 6, 2022 13:47
@mtreinish
Copy link
Collaborator

I'll start preparing a 0.7.1 release it's low overhead to get it out to fix this. There might be some other last minute bugfixes we can include before we archive this project.

@mtreinish mtreinish added stable-backport-potential Changelog: Bugfix Include in the Fixed section of the changelog labels May 6, 2022
@BastianZim
Copy link
Contributor Author

Awesome, thank you! :)

mtreinish pushed a commit to mtreinish/qiskit-ignis that referenced this pull request May 17, 2022
@BastianZim @mtreinish
Don't include docs in discovered packages (qiskit-community#611)
c05301a 
Currently, docs is included as a separate package. This pollutes the user environment when installing the
package. This commit excludes the docs dir from the package.

(cherry picked from commit ce9c594)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BastianZim @mtreinish