Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename var_form to ansatz #31

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

t-imamichi
Copy link
Contributor

@t-imamichi t-imamichi commented Apr 1, 2021

Summary

Deal with Qiskit/qiskit#6128
Fix lint issues of 'test/regressors' #31 (comment)

Details and comments

@t-imamichi t-imamichi changed the title Change var_form to ansatz Rename var_form to ansatz Apr 1, 2021
Copy link
Contributor

@stefan-woerner stefan-woerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rename the variable form var_form to ansatz

@stefan-woerner
Copy link
Contributor

and good catch, I don't understand how the test could actually pass?

@adekusar-drl
Copy link
Collaborator

@t-imamichi Could you please also:

  • add __init__.py into test/algorithms/regressors. Without it the tests are not run by the CI.
  • rename test methods in TestNeuralNetworkRegressor from classifier to regressor.

@t-imamichi
Copy link
Contributor Author

Yes. I will fix these issues too.

@adekusar-drl
Copy link
Collaborator

@t-imamichi Thanks a lot!

@stefan-woerner stefan-woerner merged commit 3a6a456 into qiskit-community:master Apr 1, 2021
gentinettagian pushed a commit to gentinettagian/qiskit-machine-learning that referenced this pull request Dec 14, 2021
* change var_form to ansatz

* fix lint of test/regressor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants