Implement Ability to Extract Q-factors from Eigenmode Simulations #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThomasGM4 : Can you please review this? Thanks |
ThomasGM4
reviewed
May 17, 2022
This reverts commit 146b0e9. Tests would be restored to the one in main.
|
@ThomasGM4 In case all the issues have been addressed, could you please merge and close this pull request? Thanks |
|
Hey @SamarthH , stumbled across another error while doing some tests of this PR. Pretty sure it is unrelated but wanting to make certain first. |
|
May I ask what the error is? Thanks |
…ey gotten by get_frequencies().
priti-ashvin-shah-ibm
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
I have run notebooks 4.18, 4.16, 4.02, and 4.11 and didn’t have any issues.
LGTM. @SamarthH , thank you for contributing to Metal repo.
priti-ashvin-shah-ibm
added a commit
that referenced
this pull request
Jul 8, 2022
* 795 conda env python3 10 using updated tag from pyepr (#796) * Callable from collections is depreicated for python 3.10 so need to use collections.abc. * Add new tag for pyepr. * Update tags for new Metal pypi release. * Wait until Samarth s pull request is merged. * To make run_all_tests to pass. @GyeongHun had the fix. * Use later tag. * Implement Ability to Extract Q-factors from Eigenmode Simulations (#794) * Implement Ability to Extract Q-factors from Eigenmode Simulations * Updated tests * Added Tutorial * Revert "Updated tests" This reverts commit 146b0e9. Tests would be restored to the one in main. * When one plot_convergences(), then the frequiences are gathered so they gotten by get_frequencies(). * Removed solution_type variable. Replaced by pyEPR implementation * Updated tests Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> * Create a new tag for pip release. (#802) Co-authored-by: Priti Shah <Priti.Ashvin.Shah@ibm.com> * Fixed the FakeJunctionGDS error this time for Issue 733 (#801) Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> * Optimize-performance (#803) * allow for using cached s_remove and s_keep; vectorize extract_energies() * initialize chi matrix with np.empty instead of list * cache c_k, c_inv_k, l_inv_k * no need to validate input for add_interaction since it's called internally * Add python 3.10 * Change python version from number to text Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Samarth Hawaldar <47246334+SamarthH@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> Co-authored-by: Connor Bowman <58343812+bowmanconnor@users.noreply.github.com> Co-authored-by: Soham Bopardikar <bopardikarsoham@gmail.com> Co-authored-by: Yehan Liu <74025052+quantum-quant@users.noreply.github.com>
priti-ashvin-shah-ibm
added a commit
that referenced
this pull request
Aug 2, 2022
* Callable from collections is depreicated for python 3.10 so need to use collections.abc. * Add new tag for pyepr. * Update tags for new Metal pypi release. * Wait until Samarth s pull request is merged. * To make run_all_tests to pass. @GyeongHun had the fix. * Use later tag. * Python 310 ci (#806) * 795 conda env python3 10 using updated tag from pyepr (#796) * Callable from collections is depreicated for python 3.10 so need to use collections.abc. * Add new tag for pyepr. * Update tags for new Metal pypi release. * Wait until Samarth s pull request is merged. * To make run_all_tests to pass. @GyeongHun had the fix. * Use later tag. * Implement Ability to Extract Q-factors from Eigenmode Simulations (#794) * Implement Ability to Extract Q-factors from Eigenmode Simulations * Updated tests * Added Tutorial * Revert "Updated tests" This reverts commit 146b0e9. Tests would be restored to the one in main. * When one plot_convergences(), then the frequiences are gathered so they gotten by get_frequencies(). * Removed solution_type variable. Replaced by pyEPR implementation * Updated tests Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> * Create a new tag for pip release. (#802) Co-authored-by: Priti Shah <Priti.Ashvin.Shah@ibm.com> * Fixed the FakeJunctionGDS error this time for Issue 733 (#801) Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> * Optimize-performance (#803) * allow for using cached s_remove and s_keep; vectorize extract_energies() * initialize chi matrix with np.empty instead of list * cache c_k, c_inv_k, l_inv_k * no need to validate input for add_interaction since it's called internally * Add python 3.10 * Change python version from number to text Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Samarth Hawaldar <47246334+SamarthH@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> Co-authored-by: Connor Bowman <58343812+bowmanconnor@users.noreply.github.com> Co-authored-by: Soham Bopardikar <bopardikarsoham@gmail.com> Co-authored-by: Yehan Liu <74025052+quantum-quant@users.noreply.github.com> * Removing the outdated python version. * Test if sphinx is working now while we are doing a small pull request. * We want to use python 3.8 or higher. * We want to use python 3.9 or higher. * Use only python39 and python310 * Just in case for future. Co-authored-by: Gyeonghun Kim <34947229+GyeonghunKim@users.noreply.github.com> Co-authored-by: Samarth Hawaldar <47246334+SamarthH@users.noreply.github.com> Co-authored-by: Connor Bowman <58343812+bowmanconnor@users.noreply.github.com> Co-authored-by: Soham Bopardikar <bopardikarsoham@gmail.com> Co-authored-by: Yehan Liu <74025052+quantum-quant@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
Fixed issues with the earlier pull request. Now works with Q3D.
Did you add tests to cover your changes (yes/no)?
yes
Did you update the documentation accordingly (yes/no)?
yes
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
This pull request implements the ability to render and use resistive ports in Eigenmode simulations in order to find the Q-factors of resonators and to simulate other dissipative effects.
Details and comments