Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

832 box plus buffer vs chips for Multiplanar design. #833

Merged
merged 14 commits into from
Aug 8, 2022

Conversation

priti-ashvin-shah-ibm
Copy link
Collaborator

What are the issues this pull addresses (issue numbers / links)?

Closes issue #832

Did you add tests to cover your changes (yes/no)?

Did you update the documentation accordingly (yes/no)?

Did you read the CONTRIBUTING document (yes/no)?

Summary

This is for Multiplanar Design with use of the layer_stack_handler.

Details and comments

@AbeerVaishnav13 AbeerVaishnav13 marked this pull request as ready for review August 4, 2022 12:36
AbeerVaishnav13
AbeerVaishnav13 previously approved these changes Aug 5, 2022
Copy link
Collaborator

@AbeerVaishnav13 AbeerVaishnav13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

box_minx, box_miny, box_maxx, box_maxy = box_for_xy_bounds
safe_xy_box = list()
# Keep the order of appends in this way. It should match (minx, miny, maxx, maxy)
if box_minx < chip_minx:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A perhaps cleaner shorthand;

safe_xy_box = [chip_bounds_xy[n] if np.absolute(box_for_xy_bounds[n])>np.absolute(chip_bounds_xy[n]) else box_for_xy_bounds[n] for n in range(len(box_for_xy_bounds))]

Tested it but probably should double check it gives the desired output

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree cleaner shorthand would be nice.

There is an example in image below. The below scenario would use chip box for min_x position, when the min_x of box_for_xy_bounds would be valid

image
.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting more logic into a single list comprehension becomes harder to debug and maintain code. I request, to go ahead with the pull request as it is.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change the format of code to make more compact and readable.

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit cfc00eb into main Aug 8, 2022
@priti-ashvin-shah-ibm priti-ashvin-shah-ibm deleted the 832_box_plus_buffer_vs_chips branch August 8, 2022 17:48
@priti-ashvin-shah-ibm
Copy link
Collaborator Author

close #832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants