856 toolbox metal test cases #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etal documentation in HTML without any errors.
… unit test to check that orient_me in about.py prints without errors.
… test get_platform_info in about.py. Which returns a string with the platform information if no errors are present.
…ispelling of exception in test_toolbox_metal_instantiation_qlibrary_gui_exception().
cdelnano
requested review from
JeremyDrysdale-ibm,
ThomasGM4,
obrienpja and
priti-ashvin-shah-ibm
and removed request for
JeremyDrysdale-ibm
priti-ashvin-shah-ibm
previously approved these changes
Oct 7, 2022
ThomasGM4
requested changes
Oct 11, 2022
cdelnano
dismissed stale reviews from obrienpja and priti-ashvin-shah-ibm
via
7c94ff4
cdelnano
force-pushed
the
856_toolbox_metal_test_cases
branch
from
69cd7c1 to
7c94ff4
Compare
…on my original PR.
cdelnano
commented
Oct 11, 2022
cdelnano
requested review from
ThomasGM4,
obrienpja and
priti-ashvin-shah-ibm
priti-ashvin-shah-ibm
approved these changes
Oct 11, 2022
ThomasGM4
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
#856 Add Additional Test Cases
Did you add tests to cover your changes (yes/no)?
yes
Did you update the documentation accordingly (yes/no)?
no (added comments in test_toolbox_metal.py)
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
Added unit tests for the following functions/methods:
Details and comments
Added unit tests to validate these functions/methods. Completed a portion of issue #856 . I would like to save this branch to continue developing on it.