Add QElmerRenderer #882
Merged
Add QElmerRenderer #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Gradient based mesh size fields - Functionality for user to define their own mesh size field function - Used already present toolbox functions instead of making my own
- TODO: recombine this with Vector in draw/utility.py
- Changed the renderer to use the new 3D vector in `qiskit_metal/draw/utility.py` - Used bad_fillet_idxs in `toolbox_python/utility_functions.py` to selectively fillet vertices
- Removed unused code - Added helpful TODO comments - Added physical group for each chip
- environment.yml - requirements.txt
AbeerVaishnav13
previously approved these changes
Feb 2, 2023
priti-ashvin-shah-ibm
previously approved these changes
Feb 2, 2023
| @@ -222,6 +244,52 @@ def test_renderer_qansysrenderer_default_setup(self): | |||
| self.assertEqual(default_setup['q3d']['solution_order'], 'High') | |||
| self.assertEqual(default_setup['q3d']['solver_type'], 'Iterative') | |||
|
|
|||
| def test_renderer_qelmer_renderer_default_setup(self): | |||
There was a problem hiding this comment.
Thank you for adding tests.
|
Can you merge the latest from main into your branch for pull request? |
priti-ashvin-shah-ibm
previously approved these changes
Feb 14, 2023
AbeerVaishnav13
approved these changes
Mar 7, 2023
priti-ashvin-shah-ibm
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
Fixes #881
Summary
Adds ElmerFEM to available renderers in qiskit-metal.
Details
Submitting this as a draft PR. The following items need to be completed before merging:
BiCGstabl Polynomial Degreeparameter to avoid duplicate.elmer_renderer.py.elmer_runner.py.QGmshRendererto inform user if items inopen_pinslist don't exist.QElmerRendererMultiPlanarclass.AddQElmerRendereroptions toQAnalysisclassAdditional Comments
assign_netsfunction insideQElmerRendererworks properly but probably needs refactoring since it inefficiently scans through different geometries assign nets and it has grown so much it makes the code difficult to read.QElmerRenderertoQAnalysisas part of this PR. This has to be done later on when LOM2.0 gets integrated.