855 pyside2 #898
Merged
855 pyside2 #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We just copied all the requirements from the file requirements.txt so that docs has what it may need for CI testing in a virtual env. |
|
It is not elegant. I know. However, it allows us to use the next version of tox. |
obrienpja
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
LGTM, we need to fix qiskit-metal's init.py so that we can set skip_install = true in tox.ini for the docs environment, but this should suffice for now. PLEASE NOTE: Setting skip_install = false makes sure we are installing dependencies into the tox environment with setup.py. Because setup.py installs dependencies from requirements.txt (not requirements-dev.txt), all of qiskit-metal's dependencies enter the tox environment in this way when skip_install = false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
Did you add tests to cover your changes (yes/no)?
Did you update the documentation accordingly (yes/no)?
Did you read the CONTRIBUTING document (yes/no)?
Summary
Details and comments