Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest verssion of shapely since it appears that deps are not giv… #905

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

priti-ashvin-shah-ibm
Copy link
Collaborator

…ing errors. Also, font for GUI appear to be explicitly added to environment.

What are the issues this pull addresses (issue numbers / links)?

Did you add tests to cover your changes (yes/no)?

Did you update the documentation accordingly (yes/no)?

Did you read the CONTRIBUTING document (yes/no)?

Summary

Details and comments

…ing errors. Also, font for GUI appear to be explicitly added to environment.
@priti-ashvin-shah-ibm priti-ashvin-shah-ibm marked this pull request as ready for review January 11, 2023 18:07
Copy link
Collaborator

@ThomasGM4 ThomasGM4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to get a confirmation of this working on another OS setup just incase?

Copy link
Collaborator

@obrienpja obrienpja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@priti-ashvin-shah-ibm
Copy link
Collaborator Author

Did we want to get a confirmation of this working on another OS setup just incase?

Yes, I ran on a macbook pro.

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit fdc6df6 into main Jan 13, 2023
@priti-ashvin-shah-ibm priti-ashvin-shah-ibm deleted the 904_shapely_limit branch January 13, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants