Display option name and option value of failed runs in the Sweeper class' run_sweep method
#909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass' `run_sweep` method Fixes qiskit-community#907 Currently, when a run fails during the execution of Sweeper class' run_sweep method, the warning message, does not tell which option name or option value that failed. It will be useful to add which option name + option value (key) combination thatdidn't execute properly for reference in case the user wantst to run the sweeperagain for the failed option values This commit adds the option name and option value that failed to the warning message.
priti-ashvin-shah-ibm
requested review from
obrienpja,
priti-ashvin-shah-ibm and
ThomasGM4
Previously, the code changed was too long. This commit breaks the line into multiple lines to keep with the convention of keeping the lines approximately 100 characters.
priti-ashvin-shah-ibm
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
Fixes #907
Did you add tests to cover your changes (yes/no)?
No. I'm not sure how to add test cases for this particular case.
Did you update the documentation accordingly (yes/no)?
No.
Did you read the CONTRIBUTING document (yes/no)?
Yes.
Summary
Currently, when a run fails during the execution of Sweeper class' run_sweep method, the warning message, does not tell which option name or option value that failed.
It will be useful to add which option name + option value (key) combination thatdidn't execute properly for reference in case the user wantst to run the sweeperagain for the failed option values
This commit adds the option name and option value that failed to the warning message.
Details and comments