Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pyside2 version in environment.yml #925

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

cdelnano
Copy link
Collaborator

@cdelnano cdelnano commented Mar 7, 2023

What are the issues this pull addresses (issue numbers / links)?

#924

Did you add tests to cover your changes (yes/no)?

Yes, and tested that gui would run

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

I specified the version of pyside2 to be 5.15.8

Details and comments

@cdelnano cdelnano requested a review from obrienpja March 7, 2023 18:21
@priti-ashvin-shah-ibm
Copy link
Collaborator

priti-ashvin-shah-ibm commented Mar 7, 2023

Wondering if it would be consistent with both venv and conda? requirements.txt is used for venv and has pyside2 version.

Most recent version on pypi is 5.15.2.1
Released Jan 14, 2022

So, to answer my on question, no, we will have two different versions of pyside2 between conda and venv.

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm self-requested a review March 7, 2023 20:22
Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I checked on windows and we can make a conda env and start gui.

@cdelnano cdelnano merged commit d7fea1b into main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants