-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 45 q components sort filter #939
Issue 45 q components sort filter #939
Conversation
Moved this commit from my last PR #938 to a new one. Sorry for the mistake. |
To get linting to pass, save your python files with yapf formatting. |
Good Morning, |
Run yapf on all files plus a few method updates in the filter/sort logic.
You can make a draft pull request, which will run the github actions for tests. |
https://github.com/Qiskit/qiskit-metal/blob/main/.pylintrc Look at line 17 and 18 If these are autogenerated, the files need to be added here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on my mac, without M1, and it looked good. Did you test the sort of Qcomponent table window on a windows OS?
Hi. Tested in Windows 10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for your contribution.
What are the issues this pull addresses (issue numbers / links)?
#45
Did you add tests to cover your changes (yes/no)?
No. This is a UI bug fix.
Did you update the documentation accordingly (yes/no)?
No. This is a UI bug fix.
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
The QComponents table now has a QSortFilterProxyModel (see screen shots), you can now sort the table and filter using the text box.
Details and comments
Good Morning,
A fix for #45
The QComponents table now has a QSortFilterProxyModel as shown in the screen shots, you can now sort the table and filter using the text box.