-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
307 q library filtering fix #940
307 q library filtering fix #940
Conversation
This one was harder than I though. It gave me a lot of headaches :( |
Thank you so much for contributing code. I would say a good notebook to test with is : https://github.com/Qiskit/qiskit-metal/blob/main/tutorials/Appendix%20A%20Full%20design%20flow%20examples/Qiskit_Metal_IMS2022_Notebook.ipynb For your code, execute the cells prior to Simulation and Analysis and look at GUI. You will get a large set of components added to design that you can use for testing. Using this notebook, if you look at the couplers section and type Tee under library, the expected behavior will not happen. I am sure you are close to the solution. |
Update for comment #940 (comment) This bug is really though :(
Made an update to address the last comment & tested in win 10. Let me know what u think. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priti-ashvin-shah-ibm Good morning, |
@Shark-y , please work with @zlatko-minev to get to a common goal. |
@Shark-y that is really great to hear. Are you in the slack channel? That might be a great place to get a community discusison going on this |
@zlatko-minev Hi yes. I'll ask on slack. Thanks |
@zlatko-minev Hi, posted in the slack channel about that but no takers so far. Is there a specific bug you want me to fix? I am a grad student looking for a thesis topic & would like to ask if there is any research idea out there for a phd thesis using metal? Thanks |
What are the issues this pull addresses (issue numbers / links)?
#307
Did you add tests to cover your changes (yes/no)?
UI fix. Tested in Windows 10.
Did you update the documentation accordingly (yes/no)?
UI fix. No documentation available.
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
Added a filter to the QLibrary tree view. A fix for #307
Details and comments
Added a filter to the QLibrary tree view. This one was very difficult :( Note: It filters by file name