Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

307 q library filtering fix #940

Merged
merged 9 commits into from
May 10, 2023
Merged

307 q library filtering fix #940

merged 9 commits into from
May 10, 2023

Conversation

Shark-y
Copy link
Contributor

@Shark-y Shark-y commented May 9, 2023

What are the issues this pull addresses (issue numbers / links)?

#307

Did you add tests to cover your changes (yes/no)?

UI fix. Tested in Windows 10.

Did you update the documentation accordingly (yes/no)?

UI fix. No documentation available.

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

Added a filter to the QLibrary tree view. A fix for #307

Details and comments

Added a filter to the QLibrary tree view. This one was very difficult :( Note: It filters by file name

image

Shark-y and others added 8 commits May 6, 2023 20:11
Issue #549
#549

The scaling for the GDS/Q3D/HFSS dialogs should be fixed now.
Wrapped the The components table in a QSortFilterProxyModel for sorting, filtering, plus

Added a textChanged event to the filter box to display only specific items.

#45
Run yapf on all files plus a few method updates in the filter/sort logic.
@Shark-y Shark-y marked this pull request as ready for review May 9, 2023 17:02
@Shark-y
Copy link
Contributor Author

Shark-y commented May 9, 2023

This one was harder than I though. It gave me a lot of headaches :(

@priti-ashvin-shah-ibm
Copy link
Collaborator

Thank you so much for contributing code.

I would say a good notebook to test with is : https://github.com/Qiskit/qiskit-metal/blob/main/tutorials/Appendix%20A%20Full%20design%20flow%20examples/Qiskit_Metal_IMS2022_Notebook.ipynb

For your code, execute the cells prior to Simulation and Analysis and look at GUI. You will get a large set of components added to design that you can use for testing. Using this notebook, if you look at the couplers section and type Tee under library, the expected behavior will not happen. I am sure you are close to the solution.

image

Update for comment
#940 (comment)

This bug is really though :(
@Shark-y
Copy link
Contributor Author

Shark-y commented May 10, 2023

Made an update to address the last comment & tested in win 10. Let me know what u think. Thanks

Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Very nice! Great Job.

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit 99811f1 into qiskit-community:main May 10, 2023
@Shark-y
Copy link
Contributor Author

Shark-y commented May 25, 2023

@priti-ashvin-shah-ibm Good morning,
What are the desired fixes needed to move Metal from the Alpha stage into the beta? Would love to see this software advance. Thanks

@priti-ashvin-shah-ibm
Copy link
Collaborator

@Shark-y , please work with @zlatko-minev to get to a common goal.

@zlatko-minev
Copy link
Collaborator

@Shark-y that is really great to hear. Are you in the slack channel? That might be a great place to get a community discusison going on this

@Shark-y
Copy link
Contributor Author

Shark-y commented May 30, 2023

@zlatko-minev Hi yes. I'll ask on slack. Thanks

@Shark-y
Copy link
Contributor Author

Shark-y commented Jun 6, 2023

@zlatko-minev Hi, posted in the slack channel about that but no takers so far. Is there a specific bug you want me to fix? I am a grad student looking for a thesis topic & would like to ask if there is any research idea out there for a phd thesis using metal? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants