Adding datatype to the Qgeometry #983
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhant
commented
Jan 17, 2024
| @@ -2343,13 +2343,13 @@ class to a series of GDSII format on the input pd.Series. | |||
| use_width, | |||
| layer=qgeometry_element.layer, | |||
| max_points=max_points, | |||
| datatype=11) | |||
| datatype=qgeometry_element.sublayer+1) | |||
There was a problem hiding this comment.
This is temporary. I need to properly check here whether it is None or not, and make it 11 as a default.
Otherwise, I am losing the ability to have Flexpaths and Polygon on the same datatype
|
Did you get it sorted out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
It is based on Issue #982.
Did you add tests to cover your changes (yes/no)?
No.
Did you update the documentation accordingly (yes/no)?
No, only doctstrings.
Did you read the CONTRIBUTING document (yes/no)?
Yes, but I am not an experienced programmer.
Summary
I am adding the
sublayerparameter to theqgeometrydefault parameters. It corresponds to thedatatypekwarg that is being passed to thegdspy. This will allow experimentalists to have different sublayers in the GDS file. This is useful if one wants to expose areas with greater doses in lithography. This works better than creating a new layer because thecheesingis ignoring higher layers, thus it would overlap with the added feature because they correspond physically to the same layer.Details and comments
It is not working for now, and I am getting some help in the issue #982 from @zlatko-minev. It is only giving my datatypes of value 0 since I have made those changes.