Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #829 #834

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Fix #829 #834

merged 1 commit into from
Sep 22, 2022

Conversation

mrossinek
Copy link
Member

Summary

Fixes the VQEClient to correctly detect the type of the wrapped auxiliary operators. Previously, it would always wrap them into a dictionary and then fail when unwrapping them later, since it did not preserve the previously wrapped data type.

Details and comments

Closes #829

@coveralls
Copy link

coveralls commented Sep 22, 2022

Pull Request Test Coverage Report for Build 3106915718

  • 2 of 7 (28.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 85.521%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_nature/runtime/vqe_client.py 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
qiskit_nature/runtime/vqe_client.py 1 78.38%
Totals Coverage Status
Change from base Build 3099234022: -0.01%
Covered Lines: 17164
Relevant Lines: 20070

💛 - Coveralls

@woodsp-ibm
Copy link
Member

We should have a bug fix reno release note for this too right.

Fixes the VQEClient to correctly detect the type of the wrapped
auxiliary operators. Previously, it would always wrap them into a
dictionary and then fail when unwrapping them later, since it did not
preserve the previously wrapped data type.
@mrossinek mrossinek merged commit a8f2919 into qiskit-community:main Sep 22, 2022
@mrossinek mrossinek deleted the fix-829 branch September 22, 2022 16:27
@mergify mergify bot mentioned this pull request Sep 22, 2022
mergify bot pushed a commit that referenced this pull request Sep 22, 2022
Fixes the VQEClient to correctly detect the type of the wrapped
auxiliary operators. Previously, it would always wrap them into a
dictionary and then fail when unwrapping them later, since it did not
preserve the previously wrapped data type.

(cherry picked from commit a8f2919)
manoelmarques pushed a commit that referenced this pull request Sep 22, 2022
Fixes the VQEClient to correctly detect the type of the wrapped
auxiliary operators. Previously, it would always wrap them into a
dictionary and then fail when unwrapping them later, since it did not
preserve the previously wrapped data type.

(cherry picked from commit a8f2919)
mergify bot added a commit that referenced this pull request Sep 22, 2022
Fixes the VQEClient to correctly detect the type of the wrapped
auxiliary operators. Previously, it would always wrap them into a
dictionary and then fail when unwrapping them later, since it did not
preserve the previously wrapped data type.

(cherry picked from commit a8f2919)

Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
Fixes the VQEClient to correctly detect the type of the wrapped
auxiliary operators. Previously, it would always wrap them into a
dictionary and then fail when unwrapping them later, since it did not
preserve the previously wrapped data type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroundStateEigensolver with the VQEClient gives back an error
3 participants