Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy providers interface #361

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Remove legacy providers interface #361

merged 2 commits into from
Apr 20, 2022

Conversation

manoelmarques
Copy link
Contributor

Summary

See Qiskit/qiskit#7886

Details and comments

@manoelmarques manoelmarques self-assigned this Apr 12, 2022
@coveralls
Copy link

coveralls commented Apr 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2173265187

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.989%
Totals Coverage Status
Change from base Build 2173258613: 0.0%
Covered Lines: 4059
Relevant Lines: 4461
💛 - Coveralls

@woodsp-ibm
Copy link
Member

We should probably have a release note for this.

t-imamichi
t-imamichi previously approved these changes Apr 13, 2022
View reviewed changes
@manoelmarques
Copy link
Contributor Author

Terra has a release note but I will add one here too

@manoelmarques manoelmarques added the on hold Can not fix yet label Apr 13, 2022
@manoelmarques manoelmarques added priority: critical and removed on hold Can not fix yet labels Apr 20, 2022
@manoelmarques
Copy link
Contributor Author

Terra removed the legacy interfaces from its code and now the build fails. This PR needs to be merged.

@manoelmarques manoelmarques merged commit e412c49 into qiskit-community:main Apr 20, 2022
@manoelmarques manoelmarques deleted the interface branch April 20, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@t-imamichi t-imamichi t-imamichi left review comments

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

@pbark pbark Awaiting requested review from pbark

Assignees

@manoelmarques manoelmarques

Labels
priority: critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manoelmarques @coveralls @woodsp-ibm @t-imamichi