Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to runtime package #336

Open
stefanb opened this issue Jun 26, 2024 · 4 comments

Comments

@stefanb
Copy link

stefanb commented Jun 26, 2024

While testing Go 1.23 rc1 in

there was an error:

  # github.com/qjfoidnh/BaiduPCS-Go
  link: github.com/qjfoidnh/BaiduPCS-Go/pcsutil/cachepool: invalid reference to runtime.rawbyteslice

Go 1.23 no longer allows //go:linkname * runtime.* link instructioins, see

It is used in
https://github.com/search?q=repo%3Aqjfoidnh%2FBaiduPCS-Go%20linkname&type=code

@stefanb
Copy link
Author

stefanb commented Jul 18, 2024

Build is still failing with Go 1.23 rc2

@Ted-bug
Copy link

Ted-bug commented Jul 30, 2024

maybe you can try "ldflags=-checklinkname=0" if you just want to run.

@stefanb
Copy link
Author

stefanb commented Jul 30, 2024

Thanks for the workaround. I don't need to run it just for myself, I encountered this problem when trying to build it with upcoming Go 1.23 and giving you a heads-up to find a solution before it annoys more users.

stefanb added a commit to Homebrew/homebrew-core that referenced this issue Aug 1, 2024
use "go" again when qjfoidnh/BaiduPCS-Go#336 is resolved and released

To be merged after #175310
stefanb added a commit to Homebrew/homebrew-core that referenced this issue Aug 16, 2024
use "go" again when qjfoidnh/BaiduPCS-Go#336 is resolved and released

To be merged after #175310
puzzlemoondev added a commit to puzzlemoondev/BililiveRecorder-webhook-docker that referenced this issue Oct 23, 2024
pin golang at 1.22 due to baidupcs incompatibility
qjfoidnh/BaiduPCS-Go#336
puzzlemoondev added a commit to puzzlemoondev/BililiveRecorder-webhook-docker that referenced this issue Oct 23, 2024
pin golang at 1.22 due to baidupcs incompatibility
qjfoidnh/BaiduPCS-Go#336
@stefanb
Copy link
Author

stefanb commented Dec 15, 2024

Was this fixed in recent a1d6648 and just needs a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants