[QOLDEV-614] use QGOV CDN for grid scripts #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Changelog
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
|
no good, please don't 'hack' the supplied @formio packages, these are replaced often. Please use the supplied hooks and add it to the loader system instead. |
duttonw
requested changes
Nov 14, 2023
ThrawnCA
force-pushed
the
QOLDEV-614-grid-cdn-change
branch
from
de95405 to
defb91e
Compare
duttonw
requested changes
Nov 14, 2023
| @@ -168,6 +168,7 @@ const defaultInitFormioAction = () => { | |||
| const initFormio = () => { | |||
| // Init form | |||
| Formio.icons = "fontawesome"; | |||
| Formio.cdn.setOverrideUrl('grid', 'https://static.qgov.net.au/formio-qld/v2/v2.x.x-latest/'); | |||
Update docs to v2
ThrawnCA
force-pushed
the
QOLDEV-614-grid-cdn-change
branch
3 times, most recently
from
b2379d9 to
4f16763
Compare
- Allow any base URL to be provided, not just a subdomain of qgov.net.au. This lets us reuse the default function for the Gitbridge script.
ThrawnCA
force-pushed
the
QOLDEV-614-grid-cdn-change
branch
from
4f16763 to
864d9f1
Compare
duttonw
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CDN override to point 'grid' library at static.qgov.net.au