Form.io API 7.1.2 to 7.3.0 custom component fix #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fran38
approved these changes
Apr 22, 2022
| const warning = await findByText(form, `Please check your answers`); | ||
| expect(warning).toBeVisible(); | ||
| // const warning = await findByText(form, `Please check your answers`); | ||
| // expect(warning).toBeVisible(); |
duttonw
changed the title
duttonw
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Please also include ability to change all api key id's, use property lookup for logic so a user can change their payload from address1 to a1 or similar.
It is good that labels can be altered, but we should also allow low level id's as they are transmitted upstream.
| hideLabel: false, | ||
| disableClearIcon: false, | ||
| enableManualMode: true, | ||
| input: true, | ||
| persistent: "client-only", |
There was a problem hiding this comment.
this line does: validation code fires on client only, as we don't want to send data of the component to the database.
| type: "hidden", | ||
| }, | ||
| { | ||
| label: "Mode", |
There was a problem hiding this comment.
mode use to be outside of the structure, now its inside.
| // https://github.com/formio/formio.js/blob/master/src/utils/formUtils.js#L89-L90 | ||
| schema: { ...PlsPlusAddress.schema(), tree: true }, | ||
| schema: { | ||
| ...PlsPlusAddress.schema(), |
There was a problem hiding this comment.
since using fieldset component, no need for tree.
Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework PlsPlusAddress to support formio app upgrade 7.3.0
addressorcontainerwill get the issuefieldsetinstead ofcontainer