Hotfix for formio loader bug #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devonpis
commented
May 26, 2022
devonpis
commented
- fix a bug in FormioLoader
- mark PdfSubmitButton as beta
duttonw
reviewed
May 26, 2022
| @@ -23,7 +23,7 @@ const requestPluginHandler = (requestArgs, opts) => { | |||
| // the request url generated by recaptcha component doesn't honor the form options | |||
| // https://github.com/formio/formio.js/blob/master/src/components/recaptcha/ReCaptcha.js#L114 | |||
| // hence the workaround is to inject the project id to the url | |||
| if (requestArgs.url.includes(`${opts.formio.base}/recaptcha`)) { | |||
| if (requestArgs?.url?.includes(`${opts.formio.base}/recaptcha`)) { | |||
There was a problem hiding this comment.
check for object and then look for properties
There was a problem hiding this comment.
shorthand for
if (requestArgs && requestArgs.url && requestArgs.url.includes(${opts.formio.base}/recaptcha))
duttonw
approved these changes
May 26, 2022
asifaminb
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.