Complete suggested changes

qmk · Jan 6, 2023 · f1700e8 · f1700e8
1 parent 2b0b24e
commit f1700e8
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 29 deletions.
diff --git a/keyboards/junco/README.md b/keyboards/junco/README.md
@@ -1,6 +1,6 @@
 # Junco <!-- omit from toc -->
 
-![Junco](https://github.com/Daneski13/Junco/raw/main/img/Junco.webp)
+![Junco](https://i.imgur.com/WzZaIgQ.jpg)
 
 Junco is a 60% Raspberry Pi Pico powered split keyboard boasting a 4x6 layout with an aggressive columnar stagger. It has 5 "thumb" keys on either side, support for 2-4 rotary encoders, and per-key RGB lighting.
 

diff --git a/keyboards/junco/config.h b/keyboards/junco/config.h
diff --git a/keyboards/junco/junco.h b/keyboards/junco/junco.h
@@ -4,7 +4,6 @@
 #pragma once
 
 #include "quantum.h"
-#include "rev1.h"
 
 typedef union {
     uint32_t raw;

diff --git a/keyboards/junco/keymaps/via/README.md b/keyboards/junco/keymaps/via/README.md
diff --git a/keyboards/junco/rev1/config.h b/keyboards/junco/rev1/config.h
@@ -3,10 +3,6 @@
 
 #pragma once
 
-// Key matrix size (Rows are doubled-up for split)
-#define MATRIX_ROWS 10
-#define MATRIX_COLS 6
-
 // Electrical Wiring Stuff
 #define MATRIX_ROW_PINS \
     { GP8, GP9, GP10, GP11, GP12 }
@@ -16,7 +12,6 @@
 
 // Split Keyboard Stuff
 #define EE_HANDS                 // Sets the keyboard’s handedness using EEPROM
-#define SPLIT_USB_DETECT         // USB Detection to decide which side is "master"
 #define SERIAL_USART_FULL_DUPLEX // Use full duplex communication (TRRS)
 #define SERIAL_USART_TX_PIN GP0  // USART TX pin
 #define SERIAL_USART_RX_PIN GP1  // USART RX pin
@@ -25,9 +20,7 @@
 #ifdef RGB_MATRIX_ENABLE
 
 #    define RGB_DI_PIN GP15 // Pin for RGB logic
-#    define RGBLED_NUM 74   // Number of LEDs
-#    define DRIVER_LED_TOTAL RGBLED_NUM
-#    define RGB_MATRIX_LED_COUNT RGBLED_NUM
+#    define RGB_MATRIX_LED_COUNT 74
 #    define RGB_MATRIX_SPLIT \
         { 37, 37 } // 37 LEDs on each side
 

diff --git a/keyboards/junco/rev1/post_config.h b/keyboards/junco/rev1/post_config.h
@@ -2,13 +2,7 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 
 /* Default Bootmagic lite */
-// Top left for left side
-#ifndef BOOTMAGIC_LITE_ROW
-#    define BOOTMAGIC_LITE_ROW 0
-#endif
-#ifndef BOOTMAGIC_LITE_COLUMN
-#    define BOOTMAGIC_LITE_COLUMN 0
-#endif
+// Top left for left side is default in core
 
 // Top right for right side
 #ifndef BOOTMAGIC_LITE_ROW_RIGHT

diff --git a/keyboards/junco/rev1/rev1.h b/keyboards/junco/rev1/rev1.h