Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] UCIS input not cleared after resolving mnemonic #22438

Open
2 tasks
johanjoensson opened this issue Nov 10, 2023 · 1 comment
Open
2 tasks

[Bug] UCIS input not cleared after resolving mnemonic #22438

johanjoensson opened this issue Nov 10, 2023 · 1 comment

Comments

@johanjoensson
Copy link

Describe the Bug

After resolving a unicode mnemonic, successfully or not, the input buffer should be cleared. In the current code the old input is kept in the buffer, potentially leading to incorrect resolution of future inputs.

Ex.
enter the mnemonic "alpha", input is now "alpha". If you then enter the mnemonic "beta", input contains "betaa", which is incorrect.

I suggest using memset to zero out the input buffer at the end of ucis_finish.

Am I missing something important?

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

@lesshonor
Copy link
Contributor

related: #21128, #22351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants