Windows, Ergodox, KC_SLEP

[hia3]

Looks like after this commit KC_SLEP stopped working on Windows.

[ezuk]

Hi @hia3! Would you mind providing some more detail? Which version of Windows, maybe your keymap or repo? Or if you have positive proof that this is the issue, a PR with a possible fix?

[hia3]

Sure. I'm building with Ubuntu (VirtualBox):

mkdir repro && cd repro/
git clone https://github.com/jackhumbert/qmk_firmware.git
cd qmk_firmware/keyboards/ergodox_ez/
make keymap=ordinary

And test on Windows 10: press and hold "Media Tab" button (3rd led will turn on). Then press Sleep button - nothing will happen.

Changing all 0x0081 back to 0x0001 in tmk_core/protocol/lufa/descriptor.c helps.

Btw, regardless of this commit I've never been able to wake up the PC with ErgoDox EZ (even though waking up with another keyboard works just fine).

[ezuk]

@jackhumbert what do you think? Seems like a good isolation of a bug imho. Also, can people wake up Windows machines with the Planck? Trying to understand if this is keyboard specific.

[jackhumbert]

It looks like #963 addressed this - @hia3, if this isn't the case, please reopen this!