-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add soy20 PCB #10440
Add soy20 PCB #10440
Conversation
adds default and VIA Keymaps for soy20 pcb by DrewKeys
Much better! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some updates to conventions/terminology and culling of unused bits.
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Agreed. It was left over from the original file provided by the board makers original configurator file. Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, from the PR checklist
valid license headers on all *.c and *.h source files
GPL2/GPL3 recommended for consistency
other licenses are permitted, however they must be GPL-compatible and must allow for redistribution. Using a different license will almost certainly delay a PR getting merged.
Co-authored-by: Joel Challis <git@zvecr.com>
Added. |
@Friend-Or-F0H Can you take another look at those headers, they are not valid C comments. |
* 'master' of https://github.com/qmk/qmk_firmware: (178 commits) Docs: fix udev rules [CLI] Add c2json (qmk#8817) Improve LAYOUT macro searching (qmk#9530) CLI: update subcommands to use return instead of exit() (qmk#10323) Fixes small typo in docs (qmk#10515) Update personal keymap for Let's Split keyboard. (qmk#10536) [Keymap] Move my custom functions and keymaps to userspace (qmk#10502) [Keyboard] add support for ymd75 rev3 (qmk#10483) [Keyboard] Add soy20 PCB (qmk#10440) Fix for MIDI sustain effect issue (qmk#10361) format code according to conventions [skip ci] [Keyboard] Add Yugo-M Controller (qmk#10389) [Keymap] Add onekey keymap for OLED testing (qmk#10380) [Keymap] Add winterNebs keymaps (qmk#10328) [Keymap] Added 333fred 5x6_5 keymap (qmk#10272) [Keyboard] Add hannah60rgb rev.2 PCB (qmk#10287) Adding VIA support to katana60 rev2 (qmk#10442) OLED driver fixes (qmk#10377) IS31FL3741 driver fixup (qmk#10519) add info.json for XD75 keyboard (qmk#10523) ...
* upstream/master: (81 commits) [Keyboard] New keyboard - eiri (qmk#10529) [Keymap] Add niu mini dye sub keymap (qmk#10525) Clean ChibiOS platform files (qmk#10505) [Keyboard] LeftyNumpad Keyboard (qmk#10500) [Keyboard] add maja capslock indicator (qmk#10151) Fix issue introduced by PR#10404 (qmk#10559) Docs: fix udev rules [CLI] Add c2json (qmk#8817) Improve LAYOUT macro searching (qmk#9530) CLI: update subcommands to use return instead of exit() (qmk#10323) Fixes small typo in docs (qmk#10515) Update personal keymap for Let's Split keyboard. (qmk#10536) [Keymap] Move my custom functions and keymaps to userspace (qmk#10502) [Keyboard] add support for ymd75 rev3 (qmk#10483) [Keyboard] Add soy20 PCB (qmk#10440) Fix for MIDI sustain effect issue (qmk#10361) format code according to conventions [skip ci] [Keyboard] Add Yugo-M Controller (qmk#10389) [Keymap] Add onekey keymap for OLED testing (qmk#10380) [Keymap] Add winterNebs keymaps (qmk#10328) ...
* Add soy20 PCB adds default and VIA Keymaps for soy20 pcb by DrewKeys * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/soy20.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Agreed. It was left over from the original file provided by the board makers original configurator file. Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/info.json Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/soy20.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/info.json Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: Joel Challis <git@zvecr.com> * Updating *.c & *.h files with GPL3 license * Delete rules.mk * Delete keymap.c * Corrected Header Comments Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com>
* Add soy20 PCB adds default and VIA Keymaps for soy20 pcb by DrewKeys * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/soy20.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Agreed. It was left over from the original file provided by the board makers original configurator file. Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/soy20/info.json Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/soy20.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/default/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/info.json Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/soy20/config.h Co-authored-by: Joel Challis <git@zvecr.com> * Updating *.c & *.h files with GPL3 license * Delete rules.mk * Delete keymap.c * Corrected Header Comments Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com>
adds default and VIA Keymaps for soy20 pcb by DrewKeys
Description
Added QMK support for Soy20 PCB by DrewKeys. Folded in VIA support with PR# 335 at Via repo (the-via/keyboards#335)
Types of Changes
Issues Fixed or Closed by This PR
Corrects issues with initial pull request from PR# 10428 (#10428)
*
Checklist