Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Via for the Sofle #10446

Merged
merged 10 commits into from
Oct 2, 2020
Merged

Enable Via for the Sofle #10446

merged 10 commits into from
Oct 2, 2020

Conversation

Sturek
Copy link
Contributor

@Sturek Sturek commented Sep 25, 2020

Description

I kept as much of the original default keymap as possible. To make it more obvious which features cannot be changed in Via, I broke the OLED screens and the rotation of the encoders out into seperate files.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added keymap via Adds via keymap and/or updates keyboard for via support labels Sep 26, 2020
@zvecr zvecr requested a review from a team September 26, 2020 19:35
keyboards/sofle/keymaps/via/config.h Show resolved Hide resolved
keyboards/sofle/keymaps/via/encoder.c Show resolved Hide resolved
keyboards/sofle/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/sofle/keymaps/via/oled.c Show resolved Hide resolved
keyboards/sofle/keymaps/via/readme.md Outdated Show resolved Hide resolved
Sturek and others added 3 commits September 27, 2020 21:06
@Sturek
Copy link
Contributor Author

Sturek commented Sep 27, 2020

I should probably have commented here, sorry, still new to github. I'll paste my comment here for clarity.

I added the information to all files. Very sorry I did not have that right away, the default map does not and as I did so little modification to it, I was unsure if it was my place to put a license (and my name) on it. I hope my solution is okay. Thanks for your work!

@noroadsleft
Copy link
Member

I should probably have commented here, sorry, still new to github. I'll paste my comment here for clarity.

I added the information to all files. Very sorry I did not have that right away, the default map does not and as I did so little modification to it, I was unsure if it was my place to put a license (and my name) on it. I hope my solution is okay. Thanks for your work!

That's fine. The license headers are a fairly new requirement, and if you'll look around you'll likely find many files that should have them don't.

@noroadsleft noroadsleft requested a review from a team September 29, 2020 04:22
keyboards/sofle/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/sofle/keymaps/via/keymap.c Outdated Show resolved Hide resolved
Sturek and others added 4 commits October 2, 2020 04:38
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@Sturek Sturek requested a review from fauxpark October 2, 2020 02:42
@noroadsleft noroadsleft merged commit c01eb55 into qmk:master Oct 2, 2020
@noroadsleft
Copy link
Member

Thanks!

rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
* Added via support

* Now uses LTO_ENABLE

* Deactivated console to save space

* Update keyboards/sofle/keymaps/via/readme.md

* Added GPL license

* Update keyboards/sofle/keymaps/via/keymap.c

* Update keyboards/sofle/keymaps/via/keymap.c

* Update keyboards/sofle/keymaps/via/keymap.c

* Update keyboards/sofle/keymaps/via/keymap.c
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* Added via support

* Now uses LTO_ENABLE

* Deactivated console to save space

* Update keyboards/sofle/keymaps/via/readme.md

* Added GPL license

* Update keyboards/sofle/keymaps/via/keymap.c

* Update keyboards/sofle/keymaps/via/keymap.c

* Update keyboards/sofle/keymaps/via/keymap.c

* Update keyboards/sofle/keymaps/via/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants