Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard] Add Bm60poker support #10475

Merged
merged 23 commits into from
Oct 2, 2020
Merged

[keyboard] Add Bm60poker support #10475

merged 23 commits into from
Oct 2, 2020

Conversation

ipetepete
Copy link
Contributor

@ipetepete ipetepete commented Sep 28, 2020

Description

This has a different layout/matrix than the BM60rgb

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/bm60poker/bm60poker.c Outdated Show resolved Hide resolved
keyboards/bm60poker/bm60poker.c Outdated Show resolved Hide resolved
keyboards/bm60poker/config.h Outdated Show resolved Hide resolved
keyboards/bm60poker/bm60poker.c Show resolved Hide resolved
keyboards/bm60poker/bm60poker.c Outdated Show resolved Hide resolved
keyboards/bm60poker/keymaps/ipetepete/keymap.c Outdated Show resolved Hide resolved
keyboards/bm60poker/rules.mk Outdated Show resolved Hide resolved
keyboards/bm60poker/rules.mk Outdated Show resolved Hide resolved
keyboards/bm60poker/rules.mk Outdated Show resolved Hide resolved
keyboards/bm60poker/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team October 1, 2020 19:09
@fauxpark fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels Oct 1, 2020
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/bm60poker/bm60poker.h Outdated Show resolved Hide resolved
keyboards/bm60poker/bm60poker.h Outdated Show resolved Hide resolved
keyboards/bm60poker/config.h Outdated Show resolved Hide resolved
keyboards/bm60poker/config.h Outdated Show resolved Hide resolved
keyboards/bm60poker/info.json Outdated Show resolved Hide resolved
keyboards/bm60poker/keymaps/ipetepete/keymap.c Outdated Show resolved Hide resolved
keyboards/bm60poker/keymaps/ipetepete/keymap.c Outdated Show resolved Hide resolved
keyboards/bm60poker/keymaps/ipetepete/keymap.c Outdated Show resolved Hide resolved
keyboards/bm60poker/keymaps/ipetepete/keymap.c Outdated Show resolved Hide resolved
keyboards/bm60poker/keymaps/ipetepete/keymap.c Outdated Show resolved Hide resolved
ipetepete and others added 4 commits October 1, 2020 13:44
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
keyboards/bm60poker/keymaps/ipetepete/keymap.c Outdated Show resolved Hide resolved
keyboards/bm60poker/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/bm60poker/config.h Outdated Show resolved Hide resolved
@zvecr zvecr changed the title Bm60poker - This has a different layout/matrix than the BM60rgb [keyboard] Add Bm60poker support Oct 1, 2020
@noroadsleft noroadsleft merged commit 1e5df71 into qmk:master Oct 2, 2020
@noroadsleft
Copy link
Member

Thanks!

rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
* WIP working on new keymap

* tweaking keymap

* updated keymap

* cleaned up a little bit

* New preonic keymap

* my preonic keymap

* added mac layout

* preonic map update

* cleaning up old repo

* cleaning up to match upstream

* more cleanup

* removing old keymaps

* Added BM60 Poker

* Apply suggestions from code review

* Added license

* updated license

* updated license

* Fixed remaining licenses and added layout to rules
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* WIP working on new keymap

* tweaking keymap

* updated keymap

* cleaned up a little bit

* New preonic keymap

* my preonic keymap

* added mac layout

* preonic map update

* cleaning up old repo

* cleaning up to match upstream

* more cleanup

* removing old keymaps

* Added BM60 Poker

* Apply suggestions from code review

* Added license

* updated license

* updated license

* Fixed remaining licenses and added layout to rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants