Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xd75re Multi-layer keymap #10499

Merged
merged 10 commits into from
Oct 1, 2020
Merged

xd75re Multi-layer keymap #10499

merged 10 commits into from
Oct 1, 2020

Conversation

tomswartz07
Copy link
Contributor

Description

Add new xd75re keymap and layout.

This layout has been used and tested on several different xd75re boards and allows for preonic-style layers (raise, lower, adjust)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Oct 1, 2020
View reviewed changes
keyboards/xd75/keymaps/tomswartz07/config.h Outdated Show resolved Hide resolved
keyboards/xd75/keymaps/tomswartz07/keymap.c Outdated Show resolved Hide resolved
keyboards/xd75/keymaps/tomswartz07/readme.md Outdated Show resolved Hide resolved
@fauxpark fauxpark added the keymap label Oct 1, 2020
@fauxpark fauxpark requested a review from a team October 1, 2020 16:51
@tomswartz07 tomswartz07 requested review from fauxpark and removed request for a team October 1, 2020 17:02
Erovia
Erovia approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check if my recommendation works for you.

keyboards/xd75/keymaps/tomswartz07/keymap.c Outdated Show resolved Hide resolved
@tomswartz07 @Erovia
Update keyboards/xd75/keymaps/tomswartz07/keymap.c
f1c9314 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@Erovia Erovia merged commit 45f0449 into qmk:master Oct 1, 2020
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@tomswartz07 @fauxpark
@Erovia @rgoulter
xd75re Multi-layer keymap (qmk#10499)
067d5c9 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@tomswartz07 @fauxpark @Erovia
xd75re Multi-layer keymap (qmk#10499)
71f1a33 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomswartz07 @Erovia @fauxpark