Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E85 backlight & LED indicator updates #10678

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Conversation

kaylanm
Copy link
Contributor

@kaylanm kaylanm commented Oct 17, 2020

Description

Both the e85 soldered and hotswap PCBs support in-switch backlighting. This PR enables it for the VIA keymaps.
Also update the LED indicator code for both soldered and hotswap PCBs to handle both caps and scroll lock LEDs.

cc: @mechmerlin

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@kaylanm kaylanm changed the title E85 backlight E85 backlight & LED indicator updates Oct 17, 2020
Update LED indicator code for e85 hotswap/soldered PCBs.
@drashna drashna requested a review from a team October 18, 2020 23:48
@noroadsleft noroadsleft merged commit 5f2c434 into qmk:master Nov 6, 2020
@noroadsleft
Copy link
Member

Thanks!

@kaylanm kaylanm deleted the e85-backlight branch November 6, 2020 05:10
nicsuzor added a commit to nicsuzor/qmk_firmware that referenced this pull request Nov 14, 2020
* upstream/master: (48 commits)
  [Keymap] idobo:egstad (qmk#10783)
  Adding few Korean translated files (qmk#5895)
  [Keyboard] Keebwerk MEGA Initial commit (qmk#10777)
  Indicator LEDs as config (qmk#10816)
  add missing physical layout options and VIA support for Sesame (qmk#10471)
  [Keyboard] Fix unused variables in mschwingen modelm (qmk#10811)
  Add big spacebar defaults to Underscore33 (qmk#10731)
  Add qmk info -l to show the layouts too (qmk#10882)
  New command: qmk lint (qmk#10761)
  Updates to Talljoe's Keymaps (qmk#10115)
  [Keymap] bcat keymaps and userspace (qmk#10705)
  add dp60 indicator mode (qmk#8801)
  E85 backlight & LED indicator updates (qmk#10678)
  Add support for 4 IS31FL3731 devices (qmk#10860)
  [Keymap] add brandonschlack userspace and keymaps (qmk#10411)
  [Keymap] add ai03/polaris:mekberg (qmk#10508)
  CLI: Add `qmk clean` (qmk#10785)
  Adds support for XD84 Pro (qmk#9750)
  Freyr refactor (qmk#10833)
  KC60 refactor (qmk#10834)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants