Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic QMK support and keymap for Lotus58 Glow #12594

Closed
wants to merge 26 commits into from
Closed

Added basic QMK support and keymap for Lotus58 Glow #12594

wants to merge 26 commits into from

Conversation

TweetyDaBird
Copy link
Contributor

@TweetyDaBird TweetyDaBird commented Apr 16, 2021

Lotus58 Split keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/tweetydabird/lotus58/config.h Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/lotus58.c Show resolved Hide resolved
keyboards/tweetydabird/lotus58/lotus58.h Show resolved Hide resolved
keyboards/tweetydabird/lotus58/rev1/config.h Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/rev1/rev1.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team April 20, 2021 02:46
keyboards/tweetydabird/lotus58/keymaps/default/README.md Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/readme.md Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/readme.md Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/readme.md Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jul 8, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jul 9, 2021
keyboards/sofle/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/tweetydabird/lotus58/info.json Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/readme.md Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/readme.md Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/rules.mk Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Aug 24, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Sep 7, 2021
commit a83f0b6
Author: TweetyDaBird <markus.knutsson@tweety.se>
Date:   Tue Sep 7 15:30:28 2021 +0200

    Revert "fixed encoder position"

    This reverts commit 77284b7.

commit 77284b7
Author: TweetyDaBird <markus.knutsson@tweety.se>
Date:   Tue Sep 7 15:02:41 2021 +0200

    fixed encoder position

commit fa5d794
Merge: c6fc84f 0a9843b
Author: TweetyDaBird <markus.knutsson@tweety.se>
Date:   Fri Jul 9 21:13:37 2021 +0200

    Merge branch 'master' of https://github.com/TweetyDaBird/qmk_firmware

commit c6fc84f
Author: TweetyDaBird <markus.knutsson@tweety.se>
Date:   Fri Jul 9 21:13:00 2021 +0200

    final keymap

commit 0a9843b
Merge: 904eba2 db1eacd
Author: Markus Knutsson <markus.knutsson@tweety.se>
Date:   Thu May 20 08:49:53 2021 +0200

    Merge branch 'qmk:master' into master

commit 904eba2
Merge: 118af37 3023015
Author: Markus Knutsson <markus.knutsson@tweety.se>
Date:   Wed May 19 16:23:08 2021 +0200

    Merge branch 'qmk:master' into master

commit 118af37
Author: Markus Knutsson <markus.knutsson@tweety.se>
Date:   Fri Apr 16 10:11:17 2021 +0200

    Create README.md

commit 1320853
Author: Markus Knutsson <markus.knutsson@tweety.se>
Date:   Fri Apr 16 10:01:41 2021 +0200

    Delete readme.md

commit a33b503
Merge: ca38782 cfb09ff
Author: TweetyDaBird <markus.knutsson@tweety.se>
Date:   Fri Apr 16 10:00:46 2021 +0200

    Merge branch 'master' of https://github.com/TweetyDaBird/qmk_firmware

commit ca38782
Author: TweetyDaBird <markus.knutsson@tweety.se>
Date:   Fri Apr 16 09:59:54 2021 +0200

    added main folder

commit cfb09ff
Author: Markus Knutsson <markus.knutsson@tweety.se>
Date:   Fri Apr 16 09:58:28 2021 +0200

    Delete readme.md

commit 387e59a
Author: TweetyDaBird <markus.knutsson@tweety.se>
Date:   Fri Apr 16 09:49:19 2021 +0200

    Lotus58 Keymap

commit 37d9a67
Author: TweetyDaBird <markus.knutsson@tweety.se>
Date:   Sat Mar 13 22:10:26 2021 +0100

    Added Lotus

    Untested!
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have changes to the submodules, which need to be reverted.

Most likely, the PR needs a rebase to fix the issue. If you need help with this, let us know.

keyboards/tweetydabird/lotus58/config.h Show resolved Hide resolved
keyboards/tweetydabird/lotus58/readme.md Show resolved Hide resolved
* Hardware Supported: *The PCBs, controllers supported*
* Hardware Availability: *Links to where you can find this hardware*

Make example for this keyboard (after setting up your build environment):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add instructions on how to enter the bootloader, to flash new firmware?

Eg:

## Bootloader

Enter the bootloader in 3 ways:

* **Bootmagic reset**: Hold down the key at (0,0) in the matrix (usually the top left key or Escape) and plug in the keyboard
* **Physical reset button**: Briefly press the button on the back of the PCB - some may have pads you must short instead
* **Keycode in layout**: Press the key mapped to `RESET` if it is available

@stale
Copy link

stale bot commented Oct 30, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@keyboard-magpie
Copy link
Contributor

@TweetyDaBird we have continuing requests for firmware for this keyboard in the QMK discord- if you can address the changes or need help making them please reach out https://discord.gg/3QUsJqvwbm

@stale
Copy link

stale bot commented Jan 9, 2022

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

@stale stale bot closed this Jan 9, 2022
@drashna drashna mentioned this pull request Apr 14, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants