Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin to carve out platform/protocol API - Single main loop #13843

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Begin to carve out platform/protocol API - Single main loop #13843

merged 2 commits into from
Aug 17, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 1, 2021 •
edited
Loading

Description

Right now this just creates a single main() entrypoint, with some stub functions to allow the initial abstraction of the main loop.

Further iterations should:

  • Begin to move out more common code such as call sites to keyboard_*
  • Abstract the handling of suspend
  • Roll up the existing host driver and usb util API

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 1, 2021
@zvecr zvecr force-pushed the feature/single_main branch from fee26bd to e848c70 Compare August 1, 2021 21:56
@zvecr zvecr changed the title Begin to carve out platform/protocol API Begin to carve out platform/protocol API - Single main loop Aug 1, 2021
@zvecr zvecr marked this pull request as ready for review August 2, 2021 16:57
@drashna drashna requested a review from a team August 7, 2021 05:08
@zvecr zvecr force-pushed the feature/single_main branch from e848c70 to d7e65e6 Compare August 9, 2021 22:14
@tzarc tzarc requested a review from a team August 17, 2021 18:16
@zvecr zvecr force-pushed the feature/single_main branch from d7e65e6 to 6991315 Compare August 17, 2021 23:07
@zvecr zvecr merged commit 96e2b13 into qmk:develop Aug 17, 2021
@zvecr zvecr mentioned this pull request Oct 20, 2021
Merged
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Begin to carve out platform/protocol API - Single main loop (qmk#13843)
18eb6c4 
* Begin to carve out platform/protocol API

* Fix up after rebase
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Begin to carve out platform/protocol API - Single main loop (qmk#13843)
aafd346 
* Begin to carve out platform/protocol API

* Fix up after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc