-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Y&R Studio zhou65 keyboard #14192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, just a heads up:
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
I am paying attention to this pr. after the development of this branch is completed, I think I can do some tests and simplify my keyboard files, but so far, the STM32F401 EEPROM driver I modified works well. |
The issue is that its not maintainable, as per your original PR it was added to multiple keyboards. While this can be worked round by having your own "vendor" version, my preference of course would be to merge the keyboards without eeprom support (this has been the expectation set for other f4 keyboards currently in the repo). |
OK, but this will make some functions on the F4 series keyboard work abnormally, such as via (need to read EEPROM), but I hope it can run after the merger #14195 Feature/eeprom f4 is successful. At present, it seems that the best solution is to delete the relevant code to merge. Thank you for your suggestion. |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Thanks! |
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Ryan <fauxpark@gmail.com>
Hi @jiaxin96 do you happen to have the firmware of the Korno65/Zhou65 kit with Bluetooth? context is:
|
yes, but it's not in the qmk master repo, you can find the source code in my fork (https://github.com/Oh-My-Mechanical-Keyboard/qmk_firmware), or just download the firmware of zhou65BLE version in this page (https://github.com/Oh-My-Mechanical-Keyboard/oh-my-mechanical-keyboard.github.io/releases/tag/zhou65ble). |
great then. Sorry another thing @jiaxin96 how can I put the PCB to DFU? I tried shorting the BT0 & 3V3 pins but it worked this morning, not now. |
no worry on this. I fixed this beautifully already thanks to your firmware. Thank you a lot for your help @jiaxin96 . Have a nice day. |
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist