-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move non-assignment code to post_rules.mk #14207
Conversation
9868294
to
a84a2ad
Compare
@mtei I have not done anything with helix. It reports the error I'm cleaning up in this PR. My assumption is that you're working on changes now that #8422 has been merged.
|
e49b690
to
421c58b
Compare
If you have been pinged in this comment you have a keyboard that is being changed by this PR: @Legonut @yohewi @GoTakigawa @mschwingen @KamoNanban @lfkeyboards @mtei @germ @hsgw @sigma @milestogo @filoxo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine for my keyboard. Thanks for letting me know.
Can you change the following so that when I edit https://github.com/mtei/qmk_firmware/tree/modify_14207_symmetric70_proto |
I've reverted that commit so that you can change that however you'd like. |
…_rules.mk" This reverts commit cffaf00.
649c532
to
c088fef
Compare
* qmk/develop: (31 commits) Remove BLUETOOTH_ENABLE from defaultish keymaps (qmk#14375) Change USBasp and bootloadHID bootloaders to lowercase (qmk#14354) Move non-assignment code to post_rules.mk (qmk#14207) Fix number of elements in info.json does not match errors (qmk#14213) Remove bootloader listings from rules.mk (qmk#14330) Remove commented out BLUETOOTH_ENABLE rules (qmk#14361) Align rgb/led matrix docs with current behaviour (qmk#14367) [Keyboard] Add custom pcb for Polaris (qmk#14347) Fix CRLF in lyra/rev1 (qmk#14360) [Keyboard] add lyra (qmk#13977) [Keyboard] Add Olly JF PCB (qmk#14056) Backport F_CPU/F_USB hack from system76 (qmk#14286) [Keymap] Fix Maker Keyboards Alexa Keymap (qmk#14355) [Keyboard] Add 61Key (qmk#14259) `ST7565_TIMEOUT 0` and `ST7565_DISABLE_TIMEOUT` should behave the same (qmk#14315) `OLED TIMEOUT 0` and `OLED_DISABLE_TIMEOUT` should behave the same (qmk#14302) [Keyboard] Minor tweaks to Work Board layout (qmk#14351) Bugfix for Joystick and JSON schema (qmk#14295) [Keyboard] Add new Mokey keyboard (qmk#14329) [Keymap] Add Gaston's Lily58 custom keymap (qmk#14334) ...
* 40percentclub/ut47: move non-assignment code to post_rules.mk * converter/palm_usb: move non-assignment code to post_rules.mk * converter/sun_usb: move non-assignment code to post_rules.mk * dm9records/ergoinu: move non-assignment code to post_rules.mk * ergotaco: move non-assignment code to post_rules.mk * handwired/symmetric70_proto: move non-assignment code to post_rules.mk * hhkb/ansi: move non-assignment code to post_rules.mk * hhkb/jp: move non-assignment code to post_rules.mk * lfkeyboards/lfk78: move non-assignment code to post_rules.mk * lfkeyboards/lfk87: move non-assignment code to post_rules.mk * lfkeyboards/lfkpad: move non-assignment code to post_rules.mk * lfkeyboards/mini1800: move non-assignment code to post_rules.mk * manta60: move non-assignment code to post_rules.mk * mschwingen/modelm: move non-assignment code to post_rules.mk * newgame40: move non-assignment code to post_rules.mk * numatreus: move non-assignment code to post_rules.mk * rgbkb/zen: move non-assignment code to post_rules.mk * rgbkb/zen/rev2: move non-assignment code to post_rules.mk * Revert "handwired/symmetric70_proto: move non-assignment code to post_rules.mk" This reverts commit cffaf00.
Description
Types of Changes
Checklist