Split out HAPTIC_ENABLE to have separate DRIVER option #14854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cli
zvecr
force-pushed
the
feature/haptic_enable_driver
branch
from
b4bacdb to
4896dd6
Compare
fauxpark
requested changes
Oct 17, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
zvecr
commented
Oct 17, 2021
drashna
approved these changes
Oct 18, 2021
|
And can confirm that it doesn't break haptics |
fauxpark
approved these changes
Oct 18, 2021
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Oct 19, 2021
* qmk/develop: (26 commits) [DOCS] Fix the STENO_COMBINEDMAP table (qmk#14883) Fix builds for ChibiOS + Cortex-M0[+] (qmk#14879) Split out HAPTIC_ENABLE to have separate DRIVER option (qmk#14854) [Core] Add support for RISC-V builds and GD32VF103 MCU (qmk#12508) Add HT32 support to core (qmk#14388) preonic/rev3_drop: Fix old custom matrix code (qmk#14857) Remove legacy Makefile functionality (qmk#14858) Infer more when building features (qmk#13890) [Keymap] added media controls, copy and paste; moved print screen (qmk#14850) [Keyboard] Add SpiderIsland 25 key keyboard (qmk#14793) [Keyboard] Update Support for The Uni (qmk#14569) Try to clarify "number of elements in info.json does not match" error (qmk#14844) [Keyboard] Fix minor typo in Ploopy Trackball Nano Docs (qmk#14717) add docs/ja/ja_doc_status.sh (qmk#14402) [Keyboard] Amended Some Pins - KiwiKeebs Macro V2 (qmk#14824) [Keyboard] Adding CK60 and CK65 (qmk#14737) [Keymap] Update Miryoku (qmk#14827) [Keymap] Drashna Keymap Updates (qmk#14842) [Keyboard] Tractyl Manuform Updates (qmk#14841) [Keymap] Added GMMK Pro keymap with RGB (qmk#14648) ...
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
* DRIVER -> ENABLE * Update generic_features.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update common_features.mk Co-authored-by: Ryan <fauxpark@gmail.com>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* DRIVER -> ENABLE * Update generic_features.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update common_features.mk Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align with recent implementation patterns, allowing the cli workaround to be removed.
Types of Changes
Checklist