Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personalizacion del teclado de AdG #15738

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Personalizacion del teclado de AdG #15738

merged 5 commits into from
Mar 10, 2022

Conversation

maherma-adg
Copy link

New template for Kyria on a spanish Mac

Description

Add files to support a Kyria keyboard trying to replace all funcionality of a spanish full keyboard from Apple.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@maherma-adg
Personalizacion del teclado de AdG
edd5bca 
Update layout description

fix symbol layer
@github-actions github-actions bot added the keymap label Jan 4, 2022
@maherma-adg @drashna
explicitly define enabled animations
82141e5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team January 6, 2022 23:41
fauxpark
fauxpark requested changes Jan 10, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keymap name should be your GitHub username.

noroadsleft
noroadsleft approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 8bcb77c into qmk:master Mar 10, 2022
@noroadsleft
Copy link
Member

Thanks!

@maherma-adg maherma-adg deleted the pullreq branch March 10, 2022 07:57
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@maherma-adg @zykrah
Personalizacion del teclado de AdG (qmk#15738)
24587d4 
* Personalizacion del teclado de AdG

Update layout description

fix symbol layer

* fix doc Colemak

* explicitly define enabled animations

* Change keymap folder name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maherma-adg @noroadsleft @drashna @fauxpark