Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MNK65 #16400

Merged
merged 26 commits into from
Mar 10, 2022
Merged

Add support for MNK65 #16400

merged 26 commits into from
Mar 10, 2022

Conversation

kopibeng
Copy link
Contributor

Description

Adds support for MONOKEI MNK65

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Adds support for MONOKEI MNK65

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

kopibeng and others added 21 commits July 8, 2021 00:28
@kopibeng
Added support for Christine, XT65E and Adelais
445b578
@kopibeng
Add support for MNK88
76093ee
@kopibeng
Add support for XT8x
bac7998
@kopibeng
Renamed XT65E to Typ65
b4fbc85
@kopibeng
Revert "Renamed XT65E to Typ65"
09baee9 
This reverts commit b4fbc85.
@kopibeng
Revert "Revert "Renamed XT65E to Typ65""
69c770d 
This reverts commit 09baee9.
@kopibeng
File reorganization
f388b55
@kopibeng
Add support for MNK88
8f6833b
@kopibeng
Update readme.md
f511645
@kopibeng @drashna
Update keyboards/kopibeng/mnk88/rules.mk
4112e79 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@kopibeng @fauxpark
Update keyboards/kopibeng/mnk88/rules.mk
c5b1e4f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kopibeng
Fix imgur link
a34fe86
@kopibeng @fauxpark
Update keyboards/kopibeng/mnk88/rules.mk
ecc6b92 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kopibeng @fauxpark
Update keyboards/kopibeng/mnk88/info.json
4940eec 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kopibeng
Update info.json
4c8d2e8 
Previous suggested change was breaking lint check, reverting back to the original.
@kopibeng @fauxpark
Update keyboards/kopibeng/mnk88/info.json
bffbf2f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kopibeng
Fix info.json
df95ecc
@kopibeng
Merge branch 'qmk:master' into master
96fcdc3
@kopibeng
Merge remote-tracking branch 'upstream/master'
515b3f0
@kopibeng
Initial commit MNK65
95a6077
@kopibeng
Update mnk65.h and readme.md
7cca055
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 19, 2022
zvecr
zvecr requested changes Feb 19, 2022
View reviewed changes
keyboards/kopibeng/mnk65/mnk65.c Outdated Show resolved Hide resolved
@kopibeng @zvecr
Update keyboards/kopibeng/mnk65/mnk65.c
ec698d7 
Co-authored-by: Joel Challis <git@zvecr.com>
drashna
drashna requested changes Feb 21, 2022
View reviewed changes
keyboards/kopibeng/mnk65/rules.mk Outdated Show resolved Hide resolved
@kopibeng @drashna
Update keyboards/kopibeng/mnk65/rules.mk
0f5203f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@kopibeng @drashna
Update keyboards/kopibeng/mnk65/readme.md
d60c5ca 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team March 7, 2022 03:38
@kopibeng @fauxpark
Update keyboards/kopibeng/mnk65/keymaps/default/keymap.c
f673652 
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
fauxpark requested changes Mar 9, 2022
View reviewed changes
keyboards/kopibeng/mnk65/rules.mk Outdated Show resolved Hide resolved
@kopibeng @fauxpark
Update keyboards/kopibeng/mnk65/rules.mk
511be8d 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna
Copy link
Member

drashna commented Mar 10, 2022

Thanks!

@drashna drashna merged commit 61a8a60 into qmk:master Mar 10, 2022
@kopibeng kopibeng mentioned this pull request Mar 20, 2022
Merged
6 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@kopibeng @drashna
@fauxpark @zvecr @zykrah
[Keyboard] Add MNK65 (qmk#16400)
528fbbd 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kopibeng @drashna @fauxpark @zvecr