Various improvements for the AnnePro2 #16579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Mar 8, 2022
drashna
reviewed
Mar 8, 2022
keyboards/annepro2/annepro2.c
Outdated
| @@ -99,6 +101,8 @@ void keyboard_post_init_kb(void) { | |||
|
|
|||
| annepro2LedGetStatus(); | |||
|
|
|||
| annepro2LedEnable(); | |||
There was a problem hiding this comment.
Not a fan of the casing, but that's mostly a nitpick.
There was a problem hiding this comment.
I agree, maybe a good PR would be to standardize the casing in this keyboard.
drashna
approved these changes
Mar 8, 2022
…trix only in the default layer, the other two still use Shine protocol to update the RGB
Jpe230
changed the title
tzarc
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements for the AnnePro2
Description
This PR implements these improvements:
My PR currently only aims to update 1 of the 3 default keymaps to enable the RGB driver, the other 2 stay with the current way of handling the RGB as they serve the purpose of showcasing in how to use the protocol.
Types of Changes
Issues Fixed or Closed by This PR
Checklist