Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YDKB Grape PCB #16661

Merged
merged 7 commits into from
Mar 26, 2022
Merged

Add YDKB Grape PCB #16661

merged 7 commits into from
Mar 26, 2022

Conversation

somepin
Copy link

@somepin somepin commented Mar 15, 2022

Description

Add QMK support for YDKB Grape PCB with default and VIA keymaps. Attempted to use the SN74x138 demultiplexer driver (#16217) at first, but some keys didn't work. Ended up using the full custom matrix from this TMK fork instead, with the required quantum calls and callback defaults added.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Keys K2C, K3D, K4E, and K5F weren't working with my attempt at using the driver, but they work with the full custom matrix.
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 15, 2022
@zvecr
Copy link
Member

zvecr commented Mar 15, 2022

From PR checklist,

prefer CUSTOM_MATRIX = lite if custom matrix used, allows for standard debounce, see custom matrix ‘lite’

Matrix implementations which provide their own debounce are generally rejected nowdays. Migrating to "lite" will at least resolve this.

keyboards/ydkb/grape/matrix.c Show resolved Hide resolved
keyboards/ydkb/grape/readme.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 16, 2022 20:03
keyboards/ydkb/grape/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ydkb/grape/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ydkb/grape/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ydkb/grape/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@somepin somepin requested a review from fauxpark March 24, 2022 22:10
@drashna drashna merged commit 7e0dde1 into qmk:master Mar 26, 2022
@somepin somepin mentioned this pull request Apr 2, 2022
6 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants