Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard level encoder function #16721

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

waffle87
Copy link
Member

Description

Added a keyboard level encoder function as many users have complained about losing encoder functionality when using QMK Configurator.

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/gmmk/pro/pro.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 24, 2022 03:44
@drashna drashna merged commit e335d62 into qmk:master Mar 24, 2022
@waffle87 waffle87 deleted the gmmk_pro_enocder branch March 24, 2022 06:33
@jordysamuel
Copy link

If encoder behavior is already determined in the keymap, pro.c interferes with the encoder behavior. I updated my branch to the latest master and my encoder configured for brightness started sending volume up and down as well.

@gourdo1
Copy link

gourdo1 commented Apr 7, 2022

@drashna @waffle87 Is there a workaround for keymaps that already have advanced encoder functions and layers? As is, this blanket applies an additional volume up/down across all layers. It can't be shut off, since "ENCODER_ENABLE = yes" is defined in rules.mk one directory up (in /ANSI), so I'm not sure I can affect it from inside my keymaps folder hierarchy.

@jordysamuel
Copy link

@drashna @waffle87 Is there a workaround for keymaps that already have advanced encoder functions and layers? As is, this blanket applies an additional volume up/down across all layers.

I just commented out the code in pro.c so it becomes a blank file. For now that seems to be the only way.

@fauxpark
Copy link
Member

fauxpark commented Apr 7, 2022

You can just set ENCODER_ENABLE = no in your keymap rules.mk.

@tzarc
Copy link
Member

tzarc commented Apr 7, 2022

Or, if you still want encoder functionality return false; at the end of your keymap's encoder_update_user().

@gourdo1
Copy link

gourdo1 commented Apr 7, 2022

Or, if you still want encoder functionality return false; at the end of your keymap's encoder_update_user().

@tzarc Thanks, this worked for me.

0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
andrebrait added a commit to andrebrait/qmk_firmware that referenced this pull request Sep 15, 2022
Fixes some user layouts that were affected by e335d62 (qmk#16721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants