Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data driven split serial implementations #17959

Closed
wants to merge 4 commits into from
Closed

Conversation

evils
Copy link

@evils evils commented Aug 9, 2022

the additions i made to get my keyboard working

Description

additions to keyboard.jsonschema (with implementations in info_config.json and info_rules.json) for:
split hand config
serial and serial driver config
via enable config
an a SPLIT_LAYER_STATE_ENABLE mapping i'm not sure i needed, but wrote...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
    • not sure, i found finding the actual implementation the best documentation on using this feature...
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

"type": "object",
"additionalProperties": false,
"properties": {
"pin": {"$ref": "qmk.definitions.v1#/mcu_pin"},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this option (SPLIT_HAND_PIN) also appears to be covered by info.py, as split.main
but that doesn't seem to work for me, the schema definition does have a split.main,
which has a pin option, but no way to set which pin to use

the associated low_is_left option seems to be missing from any merged implementations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like _extract_split_main in lib/python/qmk/info.py must be fixed then (it extracts the pin info from SPLIT_HAND_MATRIX_GRID, but not from SPLIT_HAND_PIN). The problem is that if we take the existing SPLIT_HAND_MATRIX_GRIDsplit.matrix_grid conversion as an example, the new property would be named split.pin, and I'm not sure that would be understandable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't looked further at this, but it seems like my approach is the clearer one, mostly by merit of existing...

would this PR be merged if i pull out the SPLIT_HAND_PIN part?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for split handedness, there is a larger PR in the works: #18254

@zvecr zvecr added the core label Aug 29, 2022
@zvecr zvecr self-assigned this Aug 29, 2022
@github-actions github-actions bot removed the core label Aug 31, 2022
@evils
Copy link
Author

evils commented Aug 31, 2022

resolved merge conflict

@zvecr does your self-assignment to this mean you have a plan for the changes?

@evils
Copy link
Author

evils commented Sep 21, 2022

@zvecr it's been 3 weeks since you assigned yourself to this, do you have a plan for the changes
or should i just cut out the SPLIT_HAND_PIN part, which seems to be the blocking problem?

@evils
Copy link
Author

evils commented Oct 12, 2022

@zvecr it's been 44 days since you assigned yourself to this, was that by mistake?

i've resolved another merge conflict

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 30, 2022
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants