-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data driven split serial implementations #17959
Conversation
"type": "object", | ||
"additionalProperties": false, | ||
"properties": { | ||
"pin": {"$ref": "qmk.definitions.v1#/mcu_pin"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this option (SPLIT_HAND_PIN) also appears to be covered by info.py, as split.main
but that doesn't seem to work for me, the schema definition does have a split.main,
which has a pin
option, but no way to set which pin to use
the associated low_is_left option seems to be missing from any merged implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like _extract_split_main
in lib/python/qmk/info.py
must be fixed then (it extracts the pin info from SPLIT_HAND_MATRIX_GRID
, but not from SPLIT_HAND_PIN
). The problem is that if we take the existing SPLIT_HAND_MATRIX_GRID
→ split.matrix_grid
conversion as an example, the new property would be named split.pin
, and I'm not sure that would be understandable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't looked further at this, but it seems like my approach is the clearer one, mostly by merit of existing...
would this PR be merged if i pull out the SPLIT_HAND_PIN part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for split handedness, there is a larger PR in the works: #18254
resolved merge conflict @zvecr does your self-assignment to this mean you have a plan for the changes? |
@zvecr it's been 3 weeks since you assigned yourself to this, do you have a plan for the changes |
@zvecr it's been 44 days since you assigned yourself to this, was that by mistake? i've resolved another merge conflict |
Thank you for your contribution! |
Thank you for your contribution! |
the additions i made to get my keyboard working
Description
additions to keyboard.jsonschema (with implementations in info_config.json and info_rules.json) for:
split hand config
serial and serial driver config
via enable config
an a SPLIT_LAYER_STATE_ENABLE mapping i'm not sure i needed, but wrote...
Types of Changes
Issues Fixed or Closed by This PR
Checklist