Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for HOLD_ON_OTHER_KEY_PRESS #18721

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

precondition
Copy link
Contributor

@precondition precondition commented Oct 14, 2022

Description

Add HOLD_ON_OTHER_KEY_PRESS[_PER_KEY] to data-driven files and create a suite of unit tests to verify the behaviour of modtaps, layertaps and regular keys with HOLD_ON_OTHER_KEY_PRESS.

These commits were originally a part of #15741 but that's a breaking change that will take a long time to get merged. The unit tests for HOLD_ON_OTHER_KEY_PRESS aren't particularly tied to the scope and intent of the “make-ignore-mod-tap-interrupt-the-default” PR so they can be reviewed and merged separately.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 14, 2022
@precondition
Copy link
Contributor Author

precondition commented Oct 16, 2022

CI Build error is unrelated and has already been fixed by #18704

@drashna drashna requested a review from a team October 21, 2022 00:43
@zvecr zvecr merged commit c012490 into qmk:develop Oct 22, 2022
@precondition precondition deleted the HOLD_ON_OTHER_KEY_PRESS_UNIT_TESTS branch October 23, 2022 11:01
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
* Add HOLD_ON_OTHER_KEY_PRESS to data/ files

* Add unit tests for HOLD_ON_OTHER_KEY_PRESS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants