Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Refactor xs60 with soldered and hotswap version #19049

Merged
merged 7 commits into from
Dec 6, 2022
Merged

[Keyboard] Refactor xs60 with soldered and hotswap version #19049

merged 7 commits into from
Dec 6, 2022

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Nov 13, 2022

Description

Refactor XS60 to XS60 Soldered and XS60 Hotswap

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Add XS60 Soldered
  • Add XS60 Hotswap

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 13, 2022
drashna
drashna requested changes Nov 20, 2022
View reviewed changes
keyboards/xelus/xs60/hotswap/config.h Outdated Show resolved Hide resolved
keyboards/xelus/xs60/soldered/config.h Outdated Show resolved Hide resolved
keyboards/xelus/xs60/soldered/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 30, 2022 07:03
@Xelus22 @drashna
Update keyboards/xelus/xs60/soldered/config.h
354c2b2 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@Xelus22 Xelus22 requested a review from drashna December 1, 2022 08:22
@drashna drashna requested a review from a team December 4, 2022 08:53
@fauxpark
Copy link
Member

fauxpark commented Dec 5, 2022

Probably should go to develop, actually.

@Xelus22 Xelus22 changed the base branch from master to develop December 6, 2022 01:13
@Xelus22
Copy link
Contributor Author

Xelus22 commented Dec 6, 2022

Moved to develop branch

This was referenced Dec 6, 2022
Closed
Merged
@drashna drashna merged commit 0b1d549 into qmk:develop Dec 6, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@Xelus22 @drashna @elpekenin
[Keyboard] Refactor xs60 with soldered and hotswap version (qmk#19049)
8e07442 
Co-authored-by: Drashna Jaelre <drashna@live.com>
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@Xelus22 @drashna @omikronik
[Keyboard] Refactor xs60 with soldered and hotswap version (qmk#19049)
8be9004 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @fauxpark @drashna