Fix build failures for bastardkb/tbk and jels/boaty
#19152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Nov 25, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
crembz
pushed a commit
to crembz/qmk_firmware
that referenced
this pull request
Dec 18, 2022
ohlin
added a commit
to ohlin/qmk_firmware
that referenced
this pull request
May 25, 2023
… ko-kyria * 'ko-kyria' of https://github.com/ohlin/qmk_firmware: (603 commits) Fix Czech sendstring LUT (qmk#19193) fix typo (qmk#19189) new keyboard rb1 (qmk#18164) Fix RWIN typo within keycode list (qmk#19155) [Docs] Update reference_info_json.md (qmk#18817) Add piantor (qmk#18920) 2022 Nov 26 changelog. (qmk#19164) Fix API errors in handwired/tractyl_manuform/5x6_right/arduinomicro (qmk#19166) Revert lib/usbhost changes (qmk#19165) Fix encoder_init call order in keyboard_init (qmk#19140) Change `RGB_MATRIX_STARTUP_*` defines to `RGB_MATRIX_DEFAULT_*` (qmk#19079) Fixup installation procedure for different Fedora versions. (qmk#19159) Joystick feature improvements (qmk#19052) Change `LED_MATRIX_STARTUP_*` defines to `LED_MATRIX_DEFAULT_*` (qmk#19080) Fix build failures for `bastardkb/tbk` and `jels/boaty` (qmk#19152) Fix annepro2/c18:iso_default (qmk#19147) jsonify some info.json (qmk#19146) Fixup aurora/corne on develop (qmk#19144) Additional DD backlight config (qmk#19124) [Keymap] komidore64 planck rev6 (qmk#19036) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bastardkb/tbkwas missing aquantum.hinclude.jels/boatyhas nothing wrong with it. The MCU is specified in info.json instead of rules.mk but the CLI is only looking specifically at the latter when trying to determine the protocol, leading to it falling back toLUFA. Since info.jsonprocessoris guaranteed to be present in order to call the appropriate*_processor_rules(), let's look at that instead.Types of Changes
Issues Fixed or Closed by This PR
Checklist