Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Prevent dynamic keymaps from processing layers that don't exist #19225

Merged
merged 6 commits into from
Jan 1, 2023
Merged

[Bug] Prevent dynamic keymaps from processing layers that don't exist #19225

merged 6 commits into from
Jan 1, 2023

Conversation

drashna
Copy link
Member

@drashna drashna commented Dec 3, 2022

Description

Should prevent edge case where layer isn't supported, but keycode is added.

Tested change on work louder micro, and seems to prevent it from moving to invalid layers.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core keymap via Adds via keymap and/or updates keyboard for via support labels Dec 3, 2022
@drashna drashna force-pushed the fix/dynamic_keymap_layer branch from bde17a0 to bb373c8 Compare December 3, 2022 19:41
@drashna drashna requested a review from a team December 3, 2022 21:51
@tzarc tzarc merged commit ac561b9 into qmk:develop Jan 1, 2023
@drashna drashna deleted the fix/dynamic_keymap_layer branch January 1, 2023 01:21
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@drashna @omikronik
[Bug] Prevent dynamic keymaps from processing layers that don't exist (…
6c4f114 
…qmk#19225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @tzarc