Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework input_pressed_state docs #19267

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Rework input_pressed_state docs #19267

merged 2 commits into from
Dec 8, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 8, 2022 •
edited
Loading

Description

  • avoid overwhelming users in porting guide
  • bad header level
  • not covered in info.json docs

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team December 8, 2022 19:32
@drashna drashna requested a review from a team December 8, 2022 20:38
@zvecr zvecr merged commit 6133b08 into develop Dec 8, 2022
@fauxpark fauxpark deleted the zvecr-patch-1 branch December 8, 2022 23:26
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Rework input_pressed_state docs (qmk#19267)
ceff7b1 
* Revert changes to porting

* Update reference_info_json.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @drashna