Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leader: remove qk_ prefix #19304

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Leader: remove qk_ prefix #19304

merged 1 commit into from
Dec 14, 2022

Conversation

fauxpark
Copy link
Member

Description

#19302

Reworked the API a little to align with current patterns.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 12, 2022 09:12
@drashna drashna requested a review from a team December 12, 2022 21:11
@tzarc tzarc merged commit e211756 into qmk:develop Dec 14, 2022
@fauxpark fauxpark deleted the leader-remove-qk-prefix branch December 14, 2022 02:46
@fauxpark fauxpark mentioned this pull request Dec 14, 2022
Merged
14 tasks
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@fauxpark @omikronik
Leader: remove qk_ prefix (qmk#19304)
600bc4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @tzarc