New keymap for ID75 - paryz #19350
New keymap for ID75 - paryz #19350
Conversation
|
@waffle87 Thank you for the review, I'll fix those issues whenever possible :) |
|
I think I should be ready with all those changes. I've updated my installation of QMK_MSYS and fixed the keymap for both version of the keyboard :) |
| #include QMK_KEYBOARD_H | ||
|
|
||
| #ifdef RGB_MATRIX_ENABLE | ||
| led_config_t custom_led_config = { { |
There was a problem hiding this comment.
You know, you could just move all of this to the keyboard_post_init_user function, as:
g_led_config = { {There was a problem hiding this comment.
Well, yes I guess I could. I believe that's what the compiler will do anyways, to optimize it.
There was a problem hiding this comment.
Extremely unlikely -- it's only going to have side effects after keyboard_post_init_user(). Prior to that, the keyboard-supplied values will be present.
I'll wait to see if you want to change things before merge -- your call.
There was a problem hiding this comment.
Yup, thank you for waiting, changed it. None of the changes made are breaking, so I think we can go ahead :)
Description
It's just a new, personal keymap for ID75 with layer indication and customized RGB matrix.
Types of Changes
Issues Fixed or Closed by This PR
Checklist