Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'Need at least one layout defined in info.json' check #19537

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix 'Need at least one layout defined in info.json' check #19537

merged 1 commit into from
Jan 19, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 8, 2023 •
edited
Loading

Description

19539 covers most of the failures. Remaining issues:

☒ dailycraft/stickey4: No LAYOUTs defined! Need at least one layout defined in info.json.
  encoder meh
☒ mwstudio/alicekk: No LAYOUTs defined! Need at least one layout defined in info.json.
  low quality image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Jan 8, 2023
@zvecr zvecr changed the base branch from master to develop January 8, 2023 05:10
@zvecr zvecr changed the title Fix 'No LAYOUTs defined' check Fix 'Need at least one layout defined in info.json' check Jan 8, 2023
@zvecr zvecr merged commit 0b25528 into qmk:develop Jan 19, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Fix 'No LAYOUTs defined' check (qmk#19537)
588bf8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc